Skip to content

Clean up mobile app#48607

Merged
balloob merged 3 commits intodevfrom
cleanup-mobile-app
Apr 1, 2021
Merged

Clean up mobile app#48607
balloob merged 3 commits intodevfrom
cleanup-mobile-app

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Apr 1, 2021

Breaking change

Proposed change

Some clean up for the mobile app integration that I did while trying to reproduce #46298

Update, found the bug and it now fixes #46298

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link
Copy Markdown

Hey there @robbiet480, mind taking a look at this pull request as its been labeled with an integration (mobile_app) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Comment thread tests/util/test_logging.py Outdated
@balloob balloob added this to the 2021.4.0 milestone Apr 1, 2021
@balloob balloob merged commit 051531d into dev Apr 1, 2021
@balloob balloob deleted the cleanup-mobile-app branch April 1, 2021 23:22
balloob added a commit that referenced this pull request Apr 1, 2021
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in handle_sensor_registration: Non-thread-safe operation invoked on an event loop other than the current one

4 participants